[Monitoring] Tracking fuzzing time on engine fuzzers #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
commented
Oct 23, 2024
| @@ -1507,7 +1511,7 @@ def do_engine_fuzzing(self, engine_impl): | |||
| logs.error(f'{self.fuzz_target.binary} is not in the build.') | |||
| return [], {} | |||
|
|
|||
| fuzzer_metadata.update(current_fuzzer_metadata) | |||
| fuzzer_metadata.update(cur_fuzzer_metadata) | |||
There was a problem hiding this comment.
This is to avoid linting failure due to a line too long
oliverchang
approved these changes
Oct 23, 2024
vitorguidi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clusterfuzz only tracks fuzzing time for blackbox fuzzers at the moment, this PR extends the tracking to engine fuzzers as well by emmiting the JOB_TOTAL_FUZZ_TIME and FUZZER_TOTAL_FUZZ_TIME metrics.
Since all engine fuzzing is single process/single threaded, it suffices to track start and end time for each test case run. The only difference in behavior is that only libfuzzer indicates a timeout, and thus all other engines are expected to concentrate their metrics on timeout=False.
Testing strategy
Ran a fuzz task locally and verified the code path for _TrackFuzzTime is reached and produces sane output.
Command used:
Part of #4271