[Monitoring] Adding instrumentation for bugs opened/closed #4322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorguidi
changed the title
vitorguidi
commented
Oct 12, 2024
| @@ -261,6 +261,7 @@ def _file_issue(testcase, issue_tracker, throttler): | |||
|
|
|||
| if throttler.should_throttle(testcase): | |||
| _add_triage_message(testcase, 'Skipping filing as it is throttled.') | |||
| monitoring_metrics.ISSUE_FILING_THROTTLED.increment({'fuzzer_name': testcase.fuzzer_name}) | |||
There was a problem hiding this comment.
One alternative would be to have a single ISSUE_FILLING metric, and a label to indicate throttled/success/failure, to define less metric types.
There was a problem hiding this comment.
I think it might be more convenient to have a single issue_filing metric with 3 possible values (success, failure, throttling). Same for ISSUE_CLOSING which can have two values(success, failure)
There was a problem hiding this comment.
Will send a followup one to simplify this.
…by other entrypoints
vitorguidi
force-pushed
the
feature/bugs-metrics
branch
from
ad06754 to
b2be3ef
Compare
jonathanmetzman
approved these changes
Oct 14, 2024
vitorguidi
added a commit
that referenced
this pull request
Oct 16, 2024
vitorguidi
changed the title
vitorguidi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Opening and closing bugs is the last step in the clusterfuzz user journey, and we currently do not have that instrumentation. This PR:
The only relevant label for these metrics is the fuzzer name.
For bug filing, we measure how many attempts:
For bug closing, we measure how many attempts:
Part of #4271