-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Allowing id token on oauth for appengine #4314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30ec13c
to
c49cd10
Compare
oliverchang
requested changes
Oct 11, 2024
oliverchang
approved these changes
Oct 11, 2024
oliverchang
approved these changes
Oct 11, 2024
vitorguidi
added a commit
that referenced
this pull request
Oct 11, 2024
This reverts commit 6ab160f.
vitorguidi
added a commit
that referenced
this pull request
Oct 11, 2024
vitorguidi
added a commit
that referenced
this pull request
Oct 11, 2024
vitorguidi
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to get healthchecks on appengine handlers, we need to use GCP Uptimes. They authenticate through an oauth id token. As things currently stand, oauth on appengine only supportes access tokens, so this PR solves that.
Alternatives considered
It would be ideal if we only did one api call, either to validade an id or access token. However, the specification for oauth2 does not present a standard way of, given a token, differentiating between the two. For that reason, two api calls to GCP are made.
Part of #4271