Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Allowing id token on oauth for appengine #4314

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

vitorguidi
Copy link
Collaborator

@vitorguidi vitorguidi commented Oct 11, 2024

Motivation

In order to get healthchecks on appengine handlers, we need to use GCP Uptimes. They authenticate through an oauth id token. As things currently stand, oauth on appengine only supportes access tokens, so this PR solves that.

Alternatives considered

It would be ideal if we only did one api call, either to validade an id or access token. However, the specification for oauth2 does not present a standard way of, given a token, differentiating between the two. For that reason, two api calls to GCP are made.

Part of #4271

src/appengine/libs/handler.py Outdated Show resolved Hide resolved
src/appengine/libs/handler.py Show resolved Hide resolved
src/appengine/libs/handler.py Outdated Show resolved Hide resolved
@vitorguidi vitorguidi merged commit 6ab160f into master Oct 11, 2024
7 checks passed
@vitorguidi vitorguidi deleted the feat/gae-id-token branch October 11, 2024 05:34
vitorguidi added a commit that referenced this pull request Oct 11, 2024
vitorguidi added a commit that referenced this pull request Oct 11, 2024
Reverting this to prevent outages since it got deployed late.
vitorguidi added a commit that referenced this pull request Oct 11, 2024
vitorguidi added a commit that referenced this pull request Oct 11, 2024
@vitorguidi vitorguidi changed the title Allowing id token on oauth for appengine [Monitoring] Instrumenting cronjob exit codesAllowing id token on oauth for appengine Nov 8, 2024
@vitorguidi vitorguidi changed the title [Monitoring] Instrumenting cronjob exit codesAllowing id token on oauth for appengine [Monitoring] Allowing id token on oauth for appengine Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants