Issue mirrorer #2578
Merged
Issue mirrorer #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
reviewed
Mar 18, 2022
oliverchang
reviewed
Mar 21, 2022
| and testcase.github_issue_num is not None | ||
|
|
||
|
|
||
| def get_github_issue(testcase, github_access): |
There was a problem hiding this comment.
nit re naming: We can just call this get_issue to avoid code stutter.
so callers will call github.get_issue instead of the repetitive github.get_github_issue. Same with other functions in this file, e.g. file_github_issue and more.
There was a problem hiding this comment.
Ah, that makes sense.
Fixing now, thanks!
oliverchang
reviewed
Mar 21, 2022
oliverchang
reviewed
Mar 22, 2022
oliverchang
reviewed
Mar 22, 2022
oliverchang
reviewed
Mar 22, 2022
oliverchang
reviewed
Mar 22, 2022
oliverchang
approved these changes
Mar 23, 2022
oliverchang
reviewed
Mar 23, 2022
| if not repo_url: | ||
| logs.log_error('Unable to fetch the MAIN_REPO URL from job definition.') | ||
| return None | ||
| repo_name = repo_url.removeprefix(GITHUB_PREFIX) |
There was a problem hiding this comment.
Last comment: Not all main_repo values will be github. Can we add a check for this and just exit in such a a case? Log a nomal message here (not error).
Also Line 90 shouldn't be an error log either, as MAIN_REPO is not necessarily always available.
almuthanna-athamina
pushed a commit
to almuthanna-athamina/clusterfuzz
that referenced
this pull request
Jul 14, 2022
Mirror Monorail issues to the GitHub repo of the project under test. See [this doc](https://docs.google.com/document/d/11_Iozvw0Mp0qpnhOnb7Y69eVexm5wa7rSTc5JWvSVOk/edit?resourcekey=0-bxwwlTd4QVgN1f65LH9skA#) for more detail. 1. Add two properties to `FiledBug` to record the project's GitHub ID and the new issue number. 2. Parse the GitHub ID from the project's YAML file. 3. Predefine the formats of issue title&body and file/close issues with them. 4. Include `Python3` package `PyGitHub` to file/close GitHub issues. 5. Updated existing testcases to include the new `file_to_github` attribute. 6. Add testcases to verify the content of issues' title&body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirror Monorail issues to the GitHub repo of the project under test. See this doc for more detail.
FiledBugto record the project's GitHub ID and the new issue number.Python3packagePyGitHubto file/close GitHub issues.file_to_githubattribute.