Skip to content

Commit

Permalink
Ignore more check failure stack frames. (#4641) (#4642)
Browse files Browse the repository at this point in the history
Chrome check failure stack traces have changed, update the ignore
regexes to match them. This generalizes previous regexes to cover the
new variants:

```
logging::CheckLogMessage::~CheckLogMessage
logging::DCheckLogMessage::~DCheckLogMessage
logging::CheckNoreturnError::~CheckNoreturnError
logging::NotReachedLogMessage::~NotReachedLogMessage
logging::NotReachedNoreturnError::~NotReachedNoreturnError
```

cc @pbos @tsepez for future reference

Bug: https://crbug.com/389589679

Co-authored-by: Titouan Rigoudy <[email protected]>
  • Loading branch information
alhijazi and letitz authored Jan 27, 2025
1 parent 13787d5 commit 15981a9
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/clusterfuzz/stacktraces/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -552,9 +552,8 @@
r'.*libpthread',
r'.*logger',
r'.*logging::CheckError',
r'.*logging::`anonymous namespace\'::CheckLogMessage',
r'.*logging::ErrnoLogMessage',
r'.*logging::LogMessage',
r'.*logging::.*LogMessage',
r'.*logging::.*NoReturnError',
r'.*stdext::exception::what',
r'.*v8::base::OS::Abort',
r'.*Runtime_AbortCSADcheck',
Expand Down

0 comments on commit 15981a9

Please sign in to comment.