-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement string literal trim() folding #2900
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I think this PR looks OK to accept, but we do need the CLA signature to do so. |
Alright, I've signed it. |
CLAs look good, thanks! |
imported and sent for internal testing and review |
submitted internally. |
Closes google#2900 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=194607689
The ECMAScript spec requires implementations at least trim off Unicode 3.0 whitespace characters plus the BOM. I've included all of code points with the
White_Space
property from Unicode 10.0.0.