Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement string literal trim() folding #2900

Closed
wants to merge 2 commits into from
Closed

Implement string literal trim() folding #2900

wants to merge 2 commits into from

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Apr 19, 2018

The ECMAScript spec requires implementations at least trim off Unicode 3.0 whitespace characters plus the BOM. I've included all of code points with the White_Space property from Unicode 10.0.0.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@brad4d
Copy link
Contributor

brad4d commented Apr 24, 2018

@puddly

I think this PR looks OK to accept, but we do need the CLA signature to do so.

@puddly
Copy link
Contributor Author

puddly commented Apr 26, 2018

Alright, I've signed it.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@brad4d brad4d self-assigned this Apr 26, 2018
@brad4d
Copy link
Contributor

brad4d commented Apr 26, 2018

imported and sent for internal testing and review

@brad4d
Copy link
Contributor

brad4d commented Apr 27, 2018

submitted internally.
should be in Monday's push to GitHub

@puddly puddly deleted the peephole-string-trim branch April 30, 2018 23:22
Yannic pushed a commit to Yannic/com_google_closure_compiler that referenced this pull request Jul 16, 2018
Closes google#2900

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=194607689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants