Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo on #078 #210

Merged
merged 1 commit into from
Jun 12, 2018
Merged

Typo on #078 #210

merged 1 commit into from
Jun 12, 2018

Conversation

kant
Copy link
Contributor

@kant kant commented Jun 4, 2018

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

@kant
Typo on google#78
fe8cfcb 
Plus minor fixes (proposals)
@coveralls
Copy link

coveralls commented Jun 4, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 15.713% when pulling fe8cfcb on kant:patch-1 into d8a017d on google:master.

@campionfellin
Copy link
Collaborator

Line 78 looks like it was generated from index.ts here:

clasp/index.ts

Line 74 in d8a017d

* Logs out the user by deleteing client credentials.

So it's probably best to change that and then re-generate the docs using npm run docs.

@grant
Copy link
Contributor

grant commented Jun 4, 2018 •
edited
Loading

@kant Can you modify https://github.com/google/clasp/blob/master/index.ts#L74 too?
Then this PR looks good, thanks!

@grant grant merged commit 2f3eb69 into google:master Jun 12, 2018
@grant
Copy link
Contributor

grant commented Jun 12, 2018

index.ts could be changed in a different commit.

@amymariaparker2401 amymariaparker2401 mentioned this pull request Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kant @coveralls @campionfellin @grant @googlebot