Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate BCRYPT_ECDSA_PUBLIC_GENERIC_MAGIC with the P256 curve (the only EC key type we generate now). #31

Merged
merged 1 commit into from
May 3, 2021

Conversation

copybara-service[bot]
Copy link

Associate BCRYPT_ECDSA_PUBLIC_GENERIC_MAGIC with the P256 curve (the only EC key type we generate now).

It is a temporary fix for, most likely, an PCP/ncrypt bug where for generating ECDSA P256 an ECCPUBLICBLOB with BCRYPT_ECDSA_PUBLIC_GENERIC_MAGIC is returned. Tested on Win 10 Ent 10.0.19042 Build 19042 with bcrypt/ncrypt 10.0.19041.662.

@google-cla
Copy link

google-cla bot commented Apr 30, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented May 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…only EC key type we generate now).

It is a temporary fix for, most likely, an PCP/ncrypt bug where for generating ECDSA P256 an ECCPUBLICBLOB with BCRYPT_ECDSA_PUBLIC_GENERIC_MAGIC is returned.  Tested on Win 10 Ent 10.0.19042 Build 19042 with bcrypt/ncrypt 10.0.19041.662.

PiperOrigin-RevId: 371708930
@copybara-service copybara-service bot merged commit 485e2fd into master May 3, 2021
@copybara-service copybara-service bot deleted the test_371414354 branch May 3, 2021 16:07
@google-cla
Copy link

google-cla bot commented May 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants