Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for output type agreement during the compile phase #992

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Check for output type agreement during the compile phase #992

merged 2 commits into from
Aug 2, 2024

Conversation

TristonianJones
Copy link
Collaborator

Validate that CompiledRule and CompiledMatch output expression types agree.

Closes #973

@TristonianJones TristonianJones requested a review from l46kok August 2, 2024 04:37
l46kok
l46kok previously approved these changes Aug 2, 2024
View reviewed changes
@TristonianJones
Copy link
Collaborator Author

@l46kok PTAL. I missed a comment and updated nil safety

@TristonianJones TristonianJones merged commit 5bcdb8b into google:master Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l46kok l46kok l46kok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Policy Compiler] Surface type-mismatches error in a more readable fashion
2 participants
@TristonianJones @l46kok