Track sizes of comprehension results #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpbetz
force-pushed
the
fix-comprehension-chain-cost
branch
from
d422885 to
d76e4fb
Compare
jpbetz
force-pushed
the
fix-comprehension-chain-cost
branch
from
d76e4fb to
030abf1
Compare
|
@TristonianJones would you be willing to review? Any problem test cases you can think of would be really helpful. |
jpbetz
force-pushed
the
fix-comprehension-chain-cost
branch
from
030abf1 to
4464b6a
Compare
TristonianJones
requested changes
Feb 28, 2024
jpbetz
force-pushed
the
fix-comprehension-chain-cost
branch
from
4464b6a to
2623387
Compare
jpbetz
force-pushed
the
fix-comprehension-chain-cost
branch
from
2623387 to
da2e69e
Compare
TristonianJones
approved these changes
Feb 28, 2024
jpbetz
added a commit
to jpbetz/cel-go
that referenced
this pull request
Feb 28, 2024
TristonianJones
pushed a commit
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this as draft because I'm not convinced it's entirely correct. It's assuming that the result size of a comprehension matches the iteration. Does this miscount break
.filter(),.exists()...?Fixes #900