Fix cel::common_internal::IsStringLiteral

PiperOrigin-RevId: 610840806
google · Feb 27, 2024 · 6654e73 · 6654e73
1 parent 00e2607
commit 6654e73
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/common/internal/BUILD b/common/internal/BUILD
@@ -83,6 +83,7 @@ cc_library(
         "@com_google_absl//absl/base:core_headers",
         "@com_google_absl//absl/functional:overload",
         "@com_google_absl//absl/log:absl_check",
+        "@com_google_absl//absl/meta:type_traits",
         "@com_google_absl//absl/strings:cord",
         "@com_google_absl//absl/strings:string_view",
     ],

diff --git a/common/internal/shared_byte_string.h b/common/internal/shared_byte_string.h
@@ -27,14 +27,27 @@
 #include "absl/base/optimization.h"
 #include "absl/functional/overload.h"
 #include "absl/log/absl_check.h"
+#include "absl/meta/type_traits.h"
 #include "absl/strings/cord.h"
 #include "absl/strings/string_view.h"
 #include "common/internal/arena_string.h"
 #include "common/internal/reference_count.h"
 
 namespace cel::common_internal {
 
-constexpr bool IsStringLiteral(absl::string_view string);
+inline constexpr bool IsStringLiteral(absl::string_view string) {
+#ifdef ABSL_HAVE_CONSTANT_EVALUATED
+  if (!absl::is_constant_evaluated()) {
+    return false;
+  }
+#endif
+  for (const auto& c : string) {
+    if (c == '\0') {
+      return false;
+    }
+  }
+  return true;
+}
 
 inline constexpr uintptr_t kByteStringReferenceCountPooledBit = uintptr_t{1}
                                                                 << 0;