Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary dependencies smoketest #240

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Binary dependencies smoketest #240

merged 2 commits into from
Oct 14, 2020

Conversation

UebelAndre
Copy link
Collaborator

This contains the changes in #227 and should not be merged until that PR gets merged and this PR is rebased on top of that.

acmcarther
acmcarther approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@acmcarther acmcarther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm LGTMing blind here. too lazy to look through each and every file.

Anything here you think deserves some extra attention? Else, just LGTM.

README.md Outdated Show resolved Hide resolved
@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Oct 8, 2020 •
edited
Loading

The only thing you should take a look at is d96e3ba

edit: Updated hash

@UebelAndre UebelAndre mentioned this pull request Oct 12, 2020
Merged
@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Oct 13, 2020 •
edited
Loading

@acmcarther this PR has been rebased. The only change worth taking a look at is d96e3ba

@acmcarther
Copy link
Member

LGTM

@acmcarther acmcarther merged commit 05a45b9 into google:master Oct 14, 2020
@UebelAndre UebelAndre deleted the binary-dependencies-smoketest branch October 15, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmcarther acmcarther acmcarther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @acmcarther