Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional tests for gke.types and gke.util #84

Merged
merged 4 commits into from
Aug 13, 2020
Merged

Conversation

ajslone
Copy link
Collaborator

@ajslone ajslone commented Aug 13, 2020

This PR adds additional tests for caliban.platform.gke.types and caliban.platform.gke.util.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #84 into master will increase coverage by 2.81%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   51.83%   54.65%   +2.81%     
==========================================
  Files          31       31              
  Lines        3158     3160       +2     
==========================================
+ Hits         1637     1727      +90     
+ Misses       1521     1433      -88     
Impacted Files Coverage Δ
caliban/platform/gke/types.py 100.00% <100.00%> (+36.66%) ⬆️
caliban/platform/gke/util.py 100.00% <100.00%> (+29.00%) ⬆️
caliban/platform/cloud/types.py 90.50% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9062a7b...97f09e3. Read the comment docs.

@ajslone ajslone requested a review from sritchie August 13, 2020 18:13
@sritchie
Copy link
Collaborator

Fantastic!! Great work here, and excellent coverage increase.

🚢

@ajslone ajslone merged commit 883b272 into master Aug 13, 2020
@ajslone ajslone deleted the aslone/gke_coverage branch August 13, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants