Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-order custom apt-packages before pip requirements (b/163169552) #82

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

ajslone
Copy link
Collaborator

@ajslone ajslone commented Aug 12, 2020

This PR changes the docker ordering to add custom apt packages before installing python pip dependencies.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #82 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   51.80%   51.77%   -0.04%     
==========================================
  Files          31       31              
  Lines        3154     3154              
==========================================
- Hits         1634     1633       -1     
- Misses       1520     1521       +1     
Impacted Files Coverage Δ
caliban/docker/build.py 33.17% <0.00%> (ø)
caliban/util/auth.py 66.66% <0.00%> (-9.53%) ⬇️
caliban/platform/gke/util.py 71.37% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4cb13...8826813. Read the comment docs.

@ajslone ajslone requested a review from sritchie August 12, 2020 19:00
@sritchie
Copy link
Collaborator

Looks great!

@ajslone ajslone merged commit 9062a7b into master Aug 12, 2020
@ajslone ajslone deleted the aslone/apt_pip_reorder branch August 12, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants