-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting fixes to #2743 and #2783 to 0.38 #2820
Conversation
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
…ing count of unique properties Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
…ntroduced in google#2418 Signed-off-by: Kris Gambirazzi <[email protected]>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@kgtw we need your consent to merge this PR. |
approved |
@kgtw it needs to be very special comment: #2820 (comment) |
@googlebot I consent |
Thanks for putting together cherrypick, LGTM. |
For details see:
It will allow us to get kubernetes/kubernetes#95039 fixed.