Properly initialize nested struct in influxdb test #2766
Conversation
If actually running the influxdb tests (not included in Makefile), a
compiler error occured ("cannot use promoted field in struct literal of
type") because direct access to promoted fields is only allowed in
assignments, not when initializing structs (at least, unless
golang/go#9859 gets implemented).
Signed-off-by: Jens Erat <[email protected]>
|
Hi @JensErat. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Looks extremely close to #2704 . |
|
Indeed. I actually grepped through the issues, but looks like I did not make it to the PRs. Do you want me to close this PR, or shall we wait whether @kwisniewski98 responds? I don't really care for this PR, it just blocked me from other work. :) |
|
@JensErat let's see what maintainer says :) @bobbypage, when may we expect pending PRs being merged? Some of them were file more than 3 months ago. |
|
/ok-to-test |
|
LGTM, let's merge this and close the other PR #2704 |
If actually running the influxdb tests (not included in Makefile), a compiler error occured ("cannot use promoted field in struct literal of type") because direct access to promoted fields is only allowed in assignments, not when initializing structs (at least, unless golang/go#9859 gets implemented).
The tests run fine otherwise, as soon as the required tag is added.
Jens Erat [email protected], Daimler TSS GmbH, imprint