Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the readability of perf event logs. #2689

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Increase the readability of perf event logs. #2689

merged 1 commit into from
Nov 9, 2020

Conversation

Creatone
Copy link
Collaborator

@Creatone Creatone commented Oct 2, 2020

Signed-off-by: Paweł Szulik [email protected]

@k8s-ci-robot
Copy link
Collaborator

Hi @Creatone. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla google-cla bot added the cla: yes label Oct 2, 2020
@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 9, 2020

/ok-to-test

@Creatone
Copy link
Collaborator Author

Creatone commented Nov 2, 2020 •
edited
Loading

@bobbypage can you check this one?

@bobbypage bobbypage self-assigned this Nov 4, 2020
@bobbypage
Copy link
Collaborator

LGTM, thanks.

bobbypage
bobbypage requested changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@bobbypage bobbypage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit regarding the formatting of error, otherwise LGTM

perf/uncore_libpfm.go Outdated Show resolved Hide resolved
@Creatone Creatone force-pushed the creatone/improve-perf-logs branch from c16488a to e4a04b6 Compare November 9, 2020 12:04
@Creatone Creatone force-pushed the creatone/improve-perf-logs branch from e4a04b6 to a5a48f9 Compare November 9, 2020 12:06
@bobbypage bobbypage merged commit 4f902f1 into google:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbypage bobbypage bobbypage approved these changes

Assignees

@bobbypage bobbypage

Labels
cla: yes ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Creatone @k8s-ci-robot @iwankgb @bobbypage