Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed https proxy issue by installing 'full' wget in Docker alpine-based build stage #2646

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

IzabellaRaulin
Copy link
Contributor

The default alpine 'wget' cannot handle https proxies. The solution is installing wget via apk add wget.

More about it you can read here: https://gitlab.alpinelinux.org/alpine/aports/-/issues/10446

Before:

Executing busybox-1.31.1-r16.trigger
OK: 632 MiB in 105 packages
Removing intermediate container 2c082d006a1d
 ---> 62ad5850270c
Step 3/19 : RUN wget https://sourceforge.net/projects/perfmon2/files/libpfm4/libpfm-4.10.1.tar.gz &&   tar -xzf libpfm-4.10.1.tar.gz &&   rm libpfm-4.10.1.tar.gz
 ---> Running in 4e852f499181
Connecting to proxy [...]
wget: server returned error: HTTP/1.1 400 Bad Request

After:

Executing busybox-1.31.1-r16.trigger
OK: 634 MiB in 108 packages
Removing intermediate container fb9929f9946a
 ---> f43faec7c894
Step 3/19 : RUN wget https://sourceforge.net/projects/perfmon2/files/libpfm4/libpfm-4.10.1.tar.gz &&   tar -xzf libpfm-4.10.1.tar.gz &&   rm libpfm-4.10.1.tar.gz
 ---> Running in ea6de57879c2
--2020-08-20 12:38:30--  https://sourceforge.net/projects/perfmon2/files/libpfm4/libpfm-4.10.1.tar.gz
Resolving proxy [...]
Proxy request sent, awaiting response... 200 OK
Length: 1005988 (982K) [application/x-gzip]
Saving to: 'libpfm-4.10.1.tar.gz'
[...]
2020-08-20 12:38:55 (673 KB/s) - 'libpfm-4.10.1.tar.gz' saved [1005988/1005988]

@k8s-ci-robot
Copy link
Collaborator

Hi @IzabellaRaulin. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@katarzyna-z katarzyna-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole self-assigned this Aug 20, 2020
@dashpole
Copy link
Collaborator

/ok-to-test

@IzabellaRaulin
Copy link
Contributor Author

All check passed, but it still needs review. @dashpole, might I ask you to review it?

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 6eda0c4 into google:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants