Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix journalctl leak #1729

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Fix journalctl leak #1729

merged 1 commit into from
Aug 23, 2017

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Aug 23, 2017

This fixes the journalctl leak that occurs when a process that uses
cadvisor exits. See issues #1725 and kubernetes/kubernetes#34965.

I tested this by changing the Kubelet configuration 100 times (which causes 100 restarts of cadvisor). After this, there were no leaked inotify nodes:

root@test-cos-beta-61-9765-31-0:~# for foo in /proc/*/fd/*; do readlink -f $foo; done | grep inotify | sort | uniq -c | sort -nr | awk '{print $2}' | cut -d/ -f 3 | xargs ps -p
  PID TTY      STAT   TIME COMMAND
    1 ?        Ss     0:01 /usr/lib/systemd/systemd noresume noswap cros_efi
  383 ?        Ss     0:00 /usr/lib/systemd/systemd-udevd
  516 ?        Ssl    0:00 /usr/lib/systemd/systemd-timesyncd
  579 ?        Ss     0:00 /usr/bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation
  617 ?        Ss     0:00 /usr/lib/systemd/systemd-resolved
  631 ?        Ss+    0:00 /sbin/agetty --keep-baud 115200,38400,9600 ttyS0 vt220

whereas before there were many journalctl processes associated with leaked nodes.

This fixes the journalctl leak that occurs when a process that uses
cadvisor exits. See issues google#1725 and
kubernetes/kubernetes#34965.
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a bunch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants