-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ContinueOnError for prometheus http handler. #1679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this PR:
With this PR:
|
/lgtm |
dchen1107
approved these changes
Jun 20, 2017
dchen1107
referenced
this pull request
Jun 20, 2017
Set ContinueOnError for prometheus http handler.
Thanks @Random-Liu. We should fix these metrics indeed. |
For the sake of anyone coming across this, I'll note this resulted in the output being reduced to some random subset of all metrics: it "continues" but it still drops the ones it doesn't like. See #1704 for more discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1460 upgraded prometheus to v0.8.0.
However, prometheus v0.8.0 enforced some consistency check, which our current metrics could not pass, thus caused #1671 and kubernetes/kubernetes#47744.
This PR configure prometheus http handler to
ContinueOnError
so that the metrics could be collected/exposed regardless of the error. This is also the solution suggested in prometheus/client_golang#214.This is only a quick fix for Kubernetes 1.7 release. We should figure out what in our metrics caused the inconsistency and fix it.
@dchen1107 @google/cadvisor @grobie