feat: support ignoring custom types that StandardJsonPlugin should le… #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorgan
reviewed
Jan 10, 2024
Leptopoda
force-pushed
the
feat/standard_json_plugin_ignored_list_types
branch
2 times, most recently
from
be84332 to
51fa6e6
Compare
…ave as lists Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
feat/standard_json_plugin_ignored_list_types
branch
from
51fa6e6 to
2396a29
Compare
|
Sorry for the noise. The presubmit was throwing on dart 3.0.7 making everything harder and I first had to upgrade my dart version. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ave as lists
fixes: #1295
I was not sure how to best unit test this so I just used my own usecase.
Please suggest any other ways to test this if you don't like this approach.