Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a mathematical bug #78

Merged
merged 6 commits into from
Jul 27, 2022
Merged

Fix a mathematical bug #78

merged 6 commits into from
Jul 27, 2022

Conversation

tushuhei
Copy link
Member

This change fixes the mathematical bug in the parse method, which eventually removes the necessity of the thres parameter entirely. This also fixes the deviation between the reported metrics during model training and actual quality of the results provided by the parser.

This PR includes:

  • a small fix to remove line breaks from the training data, which will make the resulting parser robust in processing punctuations that often come to the end of sentences.
  • retrained model files based on the change above.
  • updated parser implementation with correct score calculation logic and no thres parameter.

⚠️ Breaking change
thres won't be available in the parse method and the CLI options any more. Please fix your program if it's relying on the thres parameter.

@tushuhei tushuhei requested a review from kojiishi July 27, 2022 05:02
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tushuhei tushuhei merged commit 6d4bd13 into main Jul 27, 2022
@tushuhei
Copy link
Member Author

Thanks for reviewing!

@tushuhei tushuhei deleted the math-bug-fix branch December 14, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants