Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing #426

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Improve typing #426

merged 6 commits into from
Dec 20, 2023

Conversation

amitmarkel
Copy link
Contributor

No description provided.

@tushuhei tushuhei self-requested a review December 19, 2023 21:24
tushuhei
tushuhei requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@tushuhei tushuhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

javascript/src/parser.ts Outdated Show resolved Hide resolved
@amitmarkel amitmarkel changed the title Improve typing and performance Improve typing Dec 20, 2023
@amitmarkel amitmarkel requested a review from tushuhei December 20, 2023 11:15
@amitmarkel
Copy link
Contributor Author

Done: Reverted the ifs that were added and added a comment about the negative score items.

@tushuhei tushuhei requested review from tushuhei and removed request for tushuhei December 20, 2023 13:00
@tushuhei tushuhei merged commit d2ca364 into google:main Dec 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tushuhei tushuhei tushuhei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitmarkel @tushuhei