[java] Replace wholeText() with NodeVisitor
#369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kojiishi
force-pushed
the
gettext-visitor
branch
3 times, most recently
from
525fcb6 to
f5d1de8
Compare
kojiishi
force-pushed
the
gettext-visitor
branch
from
f5d1de8 to
60fae16
Compare
This patch replaces `wholeText()` implemented in google#367 by a subclass of `NodeVisitor`. Whether the `wholeText()` emits `\n` for `<br>` depends on the jsoup versions. To ensure that `getText()` always matches what `resolve()` does, this patch changes to its own logic.
kojiishi
force-pushed
the
gettext-visitor
branch
from
60fae16 to
283009b
Compare
tushuhei
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces
wholeText()implemented in #367 by a subclass ofNodeVisitor.Whether the
wholeText()emits\nfor<br>depends on the jsoup versions. To ensure thatgetText()always matches whatresolve()does, this patch changes to its own logic.