-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mypy and flake8 #34
mypy and flake8 #34
Conversation
ignore: - E111: Indentation is not a multiple of four - E501: Line too long - BLK100: black error
Type subscription in numpy (like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a lot of improvements to make our code typed! Let me ask some minor fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you so much!
I followed flake8 and
mypy --strict
and fixed their errors. And also I introduced CI of flake8 and mypy.