Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Japanese model #161

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Update the Japanese model #161

merged 3 commits into from
Jun 22, 2023

Conversation

tushuhei
Copy link
Member

Fix #160

tushuhei added 2 commits June 22, 2023 02:46
@tushuhei
Add Hiragana adverbs
c7309a2 
Change-Id: I72e2c2499e34cc90ddb5224e4967505402605e82
@tushuhei
Fix issue number
704aeed 
Change-Id: Iffb3aa00d0643e9d432e99874ac2943ec3eb84e5
@tushuhei tushuhei requested a review from kojiishi June 22, 2023 02:55
kojiishi
kojiishi previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tushuhei
Re-export the model
ab1ff6a 
Change-Id: I31e6f83aba34282ebd4fc93447dd6f6c2e8395b6
@tushuhei tushuhei merged commit 6823e9b into main Jun 22, 2023
@tushuhei
Copy link
Member Author

Thanks for reviewing!

@tushuhei tushuhei deleted the gh157 branch December 12, 2023 08:32
@tushuhei tushuhei added the quality Model quality improvements label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi left review comments

Assignees
No one assigned
Labels
quality Model quality improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[quality] Better Support for Japanese Hiragana Adverbs
2 participants
@tushuhei @kojiishi