Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defineClassAs function #119

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Remove defineClassAs function #119

merged 1 commit into from
Feb 17, 2023

Conversation

tushuhei
Copy link
Member

No description provided.

@tushuhei tushuhei requested a review from kojiishi February 16, 2023 07:46
kojiishi
kojiishi approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@kojiishi kojiishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@tushuhei tushuhei merged commit f0b6bc1 into main Feb 17, 2023
@tushuhei tushuhei deleted the remove-define-class-as branch December 12, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kojiishi kojiishi kojiishi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushuhei @kojiishi