Java code improvement (#133)

* More specific assertion error * Add RunWith annotation to tests
google · Mar 17, 2023 · 5d7a713 · 5d7a713
1 parent 5221f63
commit 5d7a713
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/java/src/main/java/com/google/budoux/HTMLProcessor.java b/java/src/main/java/com/google/budoux/HTMLProcessor.java
@@ -51,7 +51,7 @@ private HTMLProcessor() {}
       String[] skipNodesStrings = gson.fromJson(reader, String[].class);
       skipNodes = new HashSet<>(Arrays.asList(skipNodesStrings));
     } catch (JsonSyntaxException | JsonIOException | IOException e) {
-      throw new RuntimeException(e);
+      throw new AssertionError(e);
     }
   }
 

diff --git a/java/src/main/java/com/google/budoux/Parser.java b/java/src/main/java/com/google/budoux/Parser.java
@@ -98,7 +98,7 @@ public static Parser loadByFileName(String modelFileName) {
       Map<String, Map<String, Integer>> model = gson.fromJson(reader, type);
       return new Parser(model);
     } catch (JsonIOException | JsonSyntaxException | IOException e) {
-      throw new RuntimeException(e);
+      throw new AssertionError(e);
     }
   }
 

diff --git a/java/src/test/java/com/google/budoux/HTMLProcessorTest.java b/java/src/test/java/com/google/budoux/HTMLProcessorTest.java
@@ -21,8 +21,11 @@
 import java.util.Arrays;
 import java.util.List;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
 
 /** Unit tests for {@link HTMLProcessor}. */
+@RunWith(JUnit4.class)
 public class HTMLProcessorTest {
 
   @Test

diff --git a/java/src/test/java/com/google/budoux/ParserTest.java b/java/src/test/java/com/google/budoux/ParserTest.java
@@ -23,8 +23,11 @@
 import java.util.List;
 import java.util.Map;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
 
 /** Unit tests for {@link Parser}. */
+@RunWith(JUnit4.class)
 public class ParserTest {
 
   @Test