-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed the whole Drag category from the browser test #8478
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One docs fix then should be good to go! Thanks for your work on this!
@BeksOmega do I need to do anything else? |
Yes! Please commit the change I suggested above =) |
@BeksOmega please review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, we put comments above the thing being commented about so that it's clear what the comment refers to. Could you move the comment about disabling the drag category above the // 'Drag',
line?
@BeksOmega done please check it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet looks good to me! Once this passes CI I'll get it merged.
Looks like formatting is failing. Could you run |
@BeksOmega done please look into it |
Looks great, thank you for your work on this! |
The basics
The details
Resolves
Fixes #8466
Proposed Changes
Removed the ‘Drag’ category from the blocks tested by toolbox_drag_test.mjs.This change ensures that the test only includes blocks that add exactly one block to the workspace upon being dragged, aligning with the test’s original intent.
Reason for Changes
Test Coverage
Documentation
Additional Information