Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed the whole Drag category from the browser test #8478

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

abhinavjha0239
Copy link
Contributor

@abhinavjha0239 abhinavjha0239 commented Aug 11, 2024

The basics

The details

Resolves

Fixes #8466

Proposed Changes

Removed the ‘Drag’ category from the blocks tested by toolbox_drag_test.mjs.

This change ensures that the test only includes blocks that add exactly one block to the workspace upon being dragged, aligning with the test’s original intent.

Reason for Changes

Test Coverage

Documentation

Additional Information

@abhinavjha0239 abhinavjha0239 requested a review from a team as a code owner August 11, 2024 15:33
Copy link

google-cla bot commented Aug 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the PR: fix Fixes a bug label Aug 11, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for gonfunko August 12, 2024 16:44
@BeksOmega BeksOmega assigned BeksOmega and unassigned gonfunko Aug 12, 2024
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Aug 12, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One docs fix then should be good to go! Thanks for your work on this!

tests/browser/test/toolbox_drag_test.mjs Show resolved Hide resolved
@abhinavjha0239
Copy link
Contributor Author

@BeksOmega do I need to do anything else?

@BeksOmega
Copy link
Collaborator

@BeksOmega do I need to do anything else?

Yes! Please commit the change I suggested above =)

@abhinavjha0239
Copy link
Contributor Author

@BeksOmega please review it.

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, we put comments above the thing being commented about so that it's clear what the comment refers to. Could you move the comment about disabling the drag category above the // 'Drag', line?

@abhinavjha0239
Copy link
Contributor Author

@BeksOmega done please check it

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet looks good to me! Once this passes CI I'll get it merged.

@BeksOmega
Copy link
Collaborator

Looks like formatting is failing. Could you run npm run format and commit the changes?

@abhinavjha0239
Copy link
Contributor Author

@BeksOmega done please look into it
Thank You

@BeksOmega
Copy link
Collaborator

Looks great, thank you for your work on this!

@BeksOmega BeksOmega changed the title fix: removed the whole Drag category from the blocks chore: removed the whole Drag category from the browser test Aug 14, 2024
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: fix Fixes a bug labels Aug 14, 2024
@BeksOmega BeksOmega merged commit ec8f9c8 into google:develop Aug 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser test toolbox_drag_test fails in Drag category because of drag_to_dupe block
3 participants