Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow fetching block bounds not including children. #8284

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

gonfunko
Copy link
Contributor

The basics

The details

Resolves

Fixes #7212

Proposed Changes

This PR adds a getBoundingRectangleWithoutChildren() method to BlockSvg that returns the bounding box for the block alone, not including its children (for C blocks) or subsequent blocks in the stack.

Reason for Changes

There was no public API to retrieve this information, and it's useful.

@gonfunko gonfunko requested a review from a team as a code owner July 10, 2024 18:32
@gonfunko gonfunko requested a review from cpcallen July 10, 2024 18:32
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 10, 2024
core/block_svg.ts Outdated Show resolved Hide resolved
@BeksOmega BeksOmega removed the request for review from cpcallen July 10, 2024 20:11
core/block_svg.ts Outdated Show resolved Hide resolved
@gonfunko gonfunko merged commit fa15cda into google:develop Jul 10, 2024
7 checks passed
@gonfunko gonfunko deleted the childless-heightwidth branch July 10, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access the block's height and width excluding child blocks
3 participants