Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add legacy warning to block factory #8234

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

maribethb
Copy link
Contributor

The basics

The details

Resolves

Fixes google/blockly-samples#2292

Proposed Changes

  • Adds a warning banner to old block factory with links to docs and new tool
  • Updates "Help" button to point to legacy documentation

Screenshot 2024-06-28 at 12 47 07 PM

Do note these links won't work until both the new tool and the documentation have been published but I have checked them for correctness

Reason for Changes

Test Coverage

Documentation

Already updated!

Additional Information

@maribethb maribethb requested a review from a team as a code owner June 28, 2024 19:52
@maribethb maribethb requested a review from BeksOmega June 28, 2024 19:52
@github-actions github-actions bot added the PR: feature Adds a feature label Jun 28, 2024
@maribethb maribethb merged commit e76daa5 into google:develop Jun 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block factory: redirect at top of old block factory
2 participants