feat!: Add context menu options for workspace comments #8035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8005
Proposed Changes
Makes it so that context menu options can be registered to apply to workspace comments. To support one option that creates a workspace comments at the click position, I also had to pass the original right click event to all of the callbacks.
Also upgrades the old workspace comments context menu options to work with the "new" (several years old at this point :P ) context menu system.
Test Coverage
Manually tested that context menu options work.
Documentation
N/A
Additional Information
N/A
Breaking changes / To fix
Removes the
commentDuplicate
,commentDelete
, andworkspaceCommentOption
exports fromBlockly.ContextMenu
. Instead you can callregisterCommentDuplicate
,registerCommentDelete
, andregisterCommentCreate
onBlockly.ContextMenuItems
respectively. Note that these don't returnLegacyContextMenuOption
objects. Instead they register the context menu options as a side effect using the non-legacy system.You can also call
Blockly.ContextMenuItems.registerCommentOptions
to register all three options at once.