feat!: migrate bubble dragging to use new dragging API #7974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: feature
BeksOmega
changed the title
github-actions
bot
added
breaking change
rachel-fenichel
approved these changes
Mar 29, 2024
BeksOmega
changed the title
BeksOmega
removed
the
breaking change
github-actions
bot
added
PR: feature
BeksOmega
changed the title
github-actions
bot
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7843
Proposed Changes
Migrates bubble dragging to use the
IDraggableinterface and a drag strategy. Just pulls in logic that was already inbubble_dragger.tsTest Coverage
Manually tested, and bubbles are indeed draggable.
Documentation
N/A
Additional Information
N/A
Breaking changes / To Fix
This deletes the
BubbleDraggerclass. If you were referencing this class, you should instead reference the Dragger class, which you can retrieve fromgesture.getCurrentDragger.