fix: comment view styling #7965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
reviewed
Mar 27, 2024
| @@ -759,22 +758,18 @@ css.register(` | |||
| .blocklyDeleteIcon { | |||
| width: 20px; | |||
| height: 20px; | |||
| display: none; | |||
| fill: var(--commentIconColour); | |||
There was a problem hiding this comment.
This should work fine, I think the problem is that you're overriding this because the actual svg has "fill" as an inline attribute.
There was a problem hiding this comment.
Nope I tried that! <image> tags basically work like <img> tags, meaning you can't style their contents.
There was a problem hiding this comment.
Alright, that's annoying and I hate all of the weird tricks to make it work :(
There was a problem hiding this comment.
Yeah it sucks, I also tried using <use> tags instead, but those just don't show up at all.
maribethb
approved these changes
Mar 27, 2024
| @@ -759,22 +758,18 @@ css.register(` | |||
| .blocklyDeleteIcon { | |||
| width: 20px; | |||
| height: 20px; | |||
| display: none; | |||
| fill: var(--commentIconColour); | |||
There was a problem hiding this comment.
Alright, that's annoying and I hate all of the weird tricks to make it work :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes
Was documenting customizing the view of workspace comments and realized there were a few things that needed fixing:
Test Coverage
Tested that all of the icons show up properly.
Documentation
This was for documentation!
Additional Information
N/A