fix: comment create and delete events #7945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/comment-events
branch
from
2ff7ffd
to
382f40e
Compare
NeilFraser
approved these changes
Mar 25, 2024
BeksOmega
commented
Mar 25, 2024
maribethb
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7909
Proposed Changes
Changes all of the comment events to use new workspace comments classes instead of the old ones.
Updates the create and delete events to use JSON.
Updates the workspace comments classes to fire create and delete events.
Test Coverage
Updates tests. Adds tests for firing the events. Manually tested undo and redo for create and delete events.
Documentation
N/A - docs for events are just reference docs, which are automatically generated.
Additional Information
N/A