Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-nullable check for block variable and removed ! in layout_ #7522 #7537

Merged
merged 4 commits into from
Sep 24, 2023

Conversation

priya-rjb
Copy link
Contributor

@priya-rjb priya-rjb commented Sep 22, 2023

The basics

The details

Resolves

Fixes #7522 #7522

Proposed Changes

Fixes flyout_horizontal.ts In [layout_] where we access the block with const block = item.block. The result was nullable, so all later uses of block have to have a [non-null assertion].
Screen Shot 2023-09-22 at 18 30 45

Reason for Changes

To avoid writing the non-null assertion, to present the horizontal bar with the categories(blocks) in an appropriate manner.

Test Coverage

We changed the variable horizontalLayout to true in playground.html to test the changes.

Documentation

We recommend updating the test coverage documentation in playground.html.

Additional Information

@priya-rjb priya-rjb requested a review from a team as a code owner September 22, 2023 22:40
@google-cla
Copy link

google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to
    validate your changes on our
    developer site.

  • All contributors must sign the Google Contributor License
    Agreement (CLA). If the google-cla bot leaves a comment on this
    PR, make sure you follow the instructions.

  • We use conventional commits
    to make versioning the package easier. Make sure your commit
    message is in the proper format
    or learn how to fix it.

  • If any of the other checks on this PR fail, you can click on
    them to learn why. It might be that your change caused a test
    failure, or that you need to double-check the
    style guide.

Thank you for opening this PR! A member of the Blockly team will review it soon.

@yuchiiii
Copy link

Hi Priya! I tried running prettier and changed the double quotes of undefined in the if statement should work.
Screen Shot 2023-09-22 at 4 19 20 PM

@yuchiiii
Copy link

Also, our pull request title should be in this format. Thank you very much for revising this!!
Screen Shot 2023-09-22 at 4 16 40 PM

core/flyout_horizontal.ts Outdated Show resolved Hide resolved
core/flyout_horizontal.ts Outdated Show resolved Hide resolved
@priya-rjb priya-rjb changed the title #7522 edits: collaborated with Hinal Patel, Swedhaa Sri Elango, & Yuchi Hsieh fix: non-nullable check for block variable and removed ! in layout_ #7522 Sep 22, 2023
@github-actions github-actions bot added the PR: fix Fixes a bug label Sep 22, 2023
core/flyout_horizontal.ts Outdated Show resolved Hide resolved
@johnnesky
Copy link
Member

Excellent, thanks for your hard work!

@johnnesky johnnesky merged commit c762d42 into google:osd Sep 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for undefined in horizontal flyout layout function
3 participants