-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: non-nullable check for block variable and removed ! in layout_ #7522 #7537
Conversation
…o, & Yuchi Hsieh
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
-
You can find tips about contributing to Blockly and how to
validate your changes on our
developer site. -
All contributors must sign the Google Contributor License
Agreement (CLA). If the google-cla bot leaves a comment on this
PR, make sure you follow the instructions. -
We use conventional commits
to make versioning the package easier. Make sure your commit
message is in the proper format
or learn how to fix it. -
If any of the other checks on this PR fail, you can click on
them to learn why. It might be that your change caused a test
failure, or that you need to double-check the
style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
Excellent, thanks for your hard work! |
The basics
The details
Resolves
Fixes #7522 #7522
Proposed Changes
Fixes flyout_horizontal.ts In [layout_] where we access the block with const block = item.block. The result was nullable, so all later uses of block have to have a [non-null assertion].
Reason for Changes
To avoid writing the non-null assertion, to present the horizontal bar with the categories(blocks) in an appropriate manner.
Test Coverage
We changed the variable horizontalLayout to true in playground.html to test the changes.
Documentation
We recommend updating the test coverage documentation in playground.html.
Additional Information