chore: clean up mutator tests #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: chore
NeilFraser
approved these changes
Aug 28, 2023
BeksOmega
commented
Aug 28, 2023
tests/browser/test/mutator_test.js
Outdated
| suiteSetup(async function () { | ||
| this.browser = await testSetup(testFileLocations.PLAYGROUND); | ||
| }); | ||
|
|
||
| test('This test mutating a block creates more inputs', async function () { | ||
| await testingMutator(this.browser, screenDirection.LTR); | ||
| test.only('Mutating a block creates more inputs', async function () { |
tests/browser/test/test_setup.js
Outdated
Comment on lines
314
to
326
| if (mutatorBlockId) { | ||
| draggedLocation = await getLocationOfBlockConnection( | ||
| browser, | ||
| draggedBlock, | ||
| draggedBlock.id, | ||
| draggedConnection, | ||
| mutatorBlockId, | ||
| ); | ||
| targetLocation = await getLocationOfBlockConnection( | ||
| browser, | ||
| targetBlock, | ||
| targetBlock.id, | ||
| targetConnection, | ||
| mutatorBlockId, | ||
| ); |
There was a problem hiding this comment.
I think we can remove this else and just always pass mutatorBlockId (which may be undefined).
BeksOmega
commented
Aug 28, 2023
core/flyout_base.ts
Outdated
| @@ -1214,6 +1214,8 @@ export abstract class Flyout extends DeleteArea implements IFlyout { | |||
|
|
|||
| // Clone the block. | |||
| const json = blocks.save(oldBlock) as blocks.State; | |||
| // TODO: Add a saveIds parameter to `save`. | |||
| json['id'] = undefined; | |||
There was a problem hiding this comment.
I'm going to revert this change because I don't want to half-fix the issue.
This reverts commit dfec88a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Follow on to #7423 that fixes up the mutator tests.
Proposed Changes
connectmethod to not need to take in the element selector.Reason for Changes
All of these things are to aid in readability.
Changes to the
connectmethod also involved partially fixing #7432, so we may want to delay those changes for now since they're not complete.Test Coverage
This is tests!
Documentation
N/A
Additional Information
N/A
](https://github.com/google/blockly/pull/7393/files)