fix: insertion marker's next blocks are real blocks #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't add next block to the insertion marker when we do an insertion marker json serialization. Also, to keep consistent with the old behavior, we don't need to add input blocks for the insertion marker. And we don't need to do a full serialization here as it will just become an insertion marker. Resolves #7383 Address issues in PR #7364 Signed-off-by: Hollow Man <[email protected]>
This was referenced Aug 12, 2023
|
I think this may need an emergency release, as the issue here is breaking the user experience significantly. |
maribethb
approved these changes
Aug 14, 2023
ericblackmonGoogle
pushed a commit
that referenced
this pull request
Aug 14, 2023
Don't add next block to the insertion marker when we do an insertion marker json serialization. Also, to keep consistent with the old behavior, we don't need to add input blocks for the insertion marker. And we don't need to do a full serialization here as it will just become an insertion marker. Resolves #7383 Address issues in PR #7364 Signed-off-by: Hollow Man <[email protected]> (cherry picked from commit 18ee0ec)
|
I'm guessing #7381 is a duplicate of this. |
Yeah, I think so. Didn't aware that was the same issue when I opened this one. |
1 task
rachel-fenichel
added a commit
that referenced
this pull request
Aug 24, 2023
This reverts commit 18ee0ec.
rachel-fenichel
added a commit
that referenced
this pull request
Aug 24, 2023
rachel-fenichel
added a commit
that referenced
this pull request
Aug 24, 2023
Merged
13 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7383 (Ignore the reasoning there, as I had no idea what caused this at the time when I opened that issue)
Address issues in PR #7364
Proposed Changes
Don't add next block to the insertion marker when we do an insertion marker json serialization.
Also, to keep consistent with the old behavior, we don't need to add input blocks for the insertion marker.
And we don't need to do a full serialization here as it will just become an insertion marker.
Behavior Before Change
The insertion marker's next blocks are real blocks and can get connected to the statements stack.
Screencast.from.2023-08-13.02-42-30.webm
Behavior After Change
Everything returned to normal, just like the old behavior.
Reason for Changes
To fix the problem.
Test Coverage
N/A
Documentation
N/A
Additional Information
N/A