feat: Export shape interfaces from ConstantProvider #7373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested review from
BeksOmega
and removed request for
rachel-fenichel
BeksOmega
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
ConstantProviders#7286Proposed Changes
Export the shape interfaces defined in the ConstantProvider file from blockRendering, or the relevant namespace (geras, zelos) for the given renderer.
Behavior Before Change
External developers have to look at the source code to see what values they should return from custom rendering methods.
Behavior After Change
After this change the External developers do not have to look at the source code for returning the custom rendering methods.
Reason for Changes
As the types related to shapes (e.g.
BasicShape,StartHat,Notch,PuzzleTab) are not exported fromBlockly.blockRenderingwhich was making the bad developing experience for the external developers.Test Coverage
Documentation
Additional Information