Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dedeprecate render functions #7359

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix: dedeprecate render functions #7359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions core/block_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,13 +1548,8 @@ export class BlockSvg
/**
* Immediately lays out and reflows a block based on its contents and
* settings.
*
* @deprecated Renders are triggered automatically when the block is modified
* (e.g. fields are modified or inputs are added). Any calls to render()
* are no longer necessary. To be removed in v11.
*/
render() {
deprecation.warn('Blockly.BlockSvg.prototype.render', 'v10', 'v11');
this.queueRender();
renderManagement.triggerQueuedRenders();
}
Expand Down
6 changes: 0 additions & 6 deletions core/workspace_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ import * as Xml from './xml.js';
import {ZoomControls} from './zoom_controls.js';
import {ContextMenuOption} from './contextmenu_registry.js';
import * as renderManagement from './render_management.js';
import * as deprecation from './utils/deprecation.js';

/** Margin around the top/bottom/left/right after a zoomToFit call. */
const ZOOM_TO_FIT_MARGIN = 20;
Expand Down Expand Up @@ -1232,13 +1231,8 @@ export class WorkspaceSvg extends Workspace implements IASTNodeLocationSvg {

/**
* Render all blocks in workspace.
*
* @deprecated Renders are triggered automatically when the block is modified
* (e.g. fields are modified or inputs are added). Any calls to render()
* are no longer necessary. To be removed in v11.
*/
render() {
deprecation.warn('Blockly.WorkspaceSvg.prototype.render', 'v10', 'v11');
// Generate list of all blocks.
const blocks = this.getAllBlocks(false);
// Render each block.
Expand Down