fix: bumping copied objects #7349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/bumping-copied-objects
branch
2 times, most recently
from
2ab0458
to
a72ac76
Compare
4 tasks
BeksOmega
force-pushed
the
fix/bumping-copied-objects
branch
from
a72ac76
to
b3ee3ba
Compare
|
@NeilFraser This is ready for review =) |
NeilFraser
approved these changes
Aug 9, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes N/A
Proposed Changes
Adds logic to bump pasted blocks out of the way of other blocks.
Adds logic to bump pasted comments out of the way of their original comment.
Reason for Changes
Pasting blocks directly on top of other blocks or within the snap radius of other connections is confusing to the end user.
Test Coverage
Added a test to make sure block create events are being fired.
Added tests to make sure the bumping is working correctly.
Documentation
N/A
Additional Information
Dependent on #7348