Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Correct typos in PR #7169 #7197

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

cpcallen
Copy link
Contributor

@cpcallen cpcallen commented Jun 22, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Three separate mistakes left only the Python and PHP chunks with the correct code for the legacy script exports.

Proposed Changes

Fix typos

Behaviour Before Change

Only python_compressed.js and php_compressed.js had correct code for legacy exports (Blockly.<Lang>) in their UMD wrappers.

Behaviour After Change

All five <lang>_compressed.js chunks get correct wrappers.

Reason for Changes

Don't want to break developer's code.

Test Coverage

Output manually checked.

Three separate mistakes left only the Python and PHP chunks with
the correct code for the legacy script exports.
@cpcallen cpcallen requested a review from a team as a code owner June 22, 2023 20:32
@cpcallen cpcallen requested a review from maribethb June 22, 2023 20:32
@github-actions github-actions bot removed the PR: fix Fixes a bug label Jun 22, 2023
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Jun 22, 2023
Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@cpcallen cpcallen enabled auto-merge (squash) June 22, 2023 20:34
@cpcallen cpcallen merged commit 7771a6d into google:develop Jun 22, 2023
@cpcallen cpcallen deleted the fix/generator-exports branch June 22, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants