fix(tests): Fix compressed mode loading #7178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to errors in PRs google#7171 and 7173 (and the author's failure to do enough local testing before submitting those PRs), compressed mode loading was broken in the playgrounds. Fix this by: - Fix a typo in bootstrap.js ("Blocky" -> "Blockly"). - Updating the chunks definitions build_tasks.js to use the new variables we expect to contain generator exports objects.
BeksOmega
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Errors in PRs #7171 and 7173 (and the author's failure to do enough local testing before submitting those PRs) that broke compressed mode loading in the playgrounds.
Proposed Changes
Behaviour Before Change
Playgrounds load in uncompressed mode but not compressed mode.
Behavior After Change
Playgrounds load in both uncompressed and compressed mode.
Reason for Changes
Facilitate testing for v10 release.