fix: remove old icon handling code #7141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/cleanup-icons
branch
2 times, most recently
from
d7a5fba
to
8575031
Compare
4 tasks
BeksOmega
force-pushed
the
fix/cleanup-icons
branch
from
8575031
to
b313fa2
Compare
maribethb
approved these changes
Jun 13, 2023
github-actions
bot
added
PR: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7042
Proposed Changes
Removes the old icon handling code, and the old icon implementation.
Reason for Changes
Cleaning up dead code.
Test Coverage
Tests pass. Also manually tested collapsed blocks w/ icons since some of that had to be rearranged.
Documentation
N/A
Additional Information
Depedent on #7132
Deprecations
The protected
Drawer.prototype.hideHiddenIcons_method has been deprecated because it is no longer necessary to manually hide icons. If you are calling this, you can safely remove the call.