Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): Fix path issue on Windows #7127

Merged
merged 1 commit into from
Jun 1, 2023
Merged

fix(build): Fix path issue on Windows #7127

merged 1 commit into from
Jun 1, 2023

Conversation

cpcallen
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6864.

Proposed Changes

Look for path.sep instead of hard-coded '/' when parsing output of closure-make-deps.

Behaviour Before Change

npm run minify (and therefore build, package, etc.) fails on Windows.

Behaviour After Change

Hopefully less failing.

@cpcallen cpcallen requested a review from a team as a code owner May 31, 2023 18:56
@cpcallen cpcallen requested a review from BeksOmega May 31, 2023 18:56
@github-actions github-actions bot added the PR: fix Fixes a bug label May 31, 2023
@cpcallen cpcallen merged commit 3ae4a61 into google:develop Jun 1, 2023
@cpcallen cpcallen mentioned this pull request Jun 20, 2023
Closed
1 task
@cpcallen cpcallen deleted the fix/6864 branch March 15, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
component: build process PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors when building on Windows (unable to identify chunk)
2 participants
@cpcallen @BeksOmega