fix: work on calling icon hooks #7100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
maribethb
approved these changes
May 19, 2023
| @@ -321,7 +328,13 @@ export class Drawer { | |||
| if (this.info_.isInsertionMarker) { | |||
| // Fields and icons are invisible on insertion marker. They still have to | |||
| // be rendered so that the block can be sized correctly. | |||
| svgGroup.setAttribute('display', 'none'); | |||
| if (isIcon((fieldInfo as Icon).icon)) { | |||
There was a problem hiding this comment.
Haha I'll do another look at cleaning this up, but I think this method just needs to be split into some submethods
There was a problem hiding this comment.
I'm assuming that when you remove handling the old types some of these if statements will go away (though maybe not here since you didn't leave the comment about removing it?) so I tried not to comment on that aspect of them, but this one got me lol. I don't think you really need to change anything here unless you think it's actually possible to improve htis. but don't bother if it will be removed in 7042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7098
Proposed Changes
Adds correctly calling the new icon hooks in a bunch of places.
Reason for Changes
Actually get the code to work for testing refactoring icons.
Test Coverage
Enabling tests yay!
Documentation
N/A
Additional Information
Two of the
initViewtests are still skipped because I need to fix #7099 first.