Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Creating structure and providing simple test for Blockly automated functional test #7076

Merged
merged 14 commits into from
May 11, 2023
Merged

Conversation

ericblackmonGoogle
Copy link
Contributor

The basics

  • [ x] I branched from develop
  • [ x] My pull request is against develop
  • [x ] My code follows the style guide
  • [x ] I ran npm run format and npm run lint

The details

Resolves

Creates the configuration for our automated functional testing and also provides a small example.

Proposed Changes

Creates the configuration for our automated functional testing and also provides a small example.

Behavior Before Change

No automated functional test run along side of the test suite

Behavior After Change

The structure for automated test now run along side of the test suite

Reason for Changes

To allow our team to begin running automated functional test

Test Coverage

It is a test

Documentation

A document detailing the test we would like to run will be done by mid next week

Additional Information

N/A

options.capabilities['goog:chromeOptions'].args.push('--disable-gpu');
}
// Use Selenium to bring up the page
const url = 'https://blockly-demo.appspot.com/static/demos/blockfactory/index.html';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to test against a local page rather than the uploaded one? I think that would give us faster feedback if we break things.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep we can, do we have any local versions for blockfactory that I can substitute?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! The block factory lives here.

But I'm realizing this relies on the compressed files, and I'm not sure if we want to build the compressed files or not. I'm pretty sure that for the playground we want to use the bootstrap logic instead.

@cpcallen How to handle local testing is blockly Eric, can you take a look?

@@ -387,6 +396,7 @@ const tasks = [
build,
renamings,
metadata,
mochaBrowser,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to be running these on every PR because they're long and it's going to slow down the submit process. I think we probably want a separate github action to run these periodically (e.g. nightly) instead.

.github/workflows/browser_test.yml Show resolved Hide resolved
.github/workflows/browser_test.yml Outdated Show resolved Hide resolved
tests/browser/test/basic_block_factory_test.js Outdated Show resolved Hide resolved
tests/browser/test/basic_block_factory_test.js Outdated Show resolved Hide resolved
.github/workflows/browser_test.yml Outdated Show resolved Hide resolved
@BeksOmega BeksOmega added the PR: feature Adds a feature label May 11, 2023
@BeksOmega BeksOmega changed the title Feat: Creating structure and providing simple test for Blockly automated functional test feat: Creating structure and providing simple test for Blockly automated functional test May 11, 2023
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels May 11, 2023
@ericblackmonGoogle ericblackmonGoogle merged commit 88fda6d into google:develop May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants