Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IIcon interface, and related interfaces #7054

Merged
merged 5 commits into from
May 9, 2023

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented May 4, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Work on #7036

Proposed Changes

Adds interfaces we need for defining icons.

Reason for Changes

Interfaces are how we keep the relationships between internal blockly code and external code clear =)

Test Coverage

N/A These are just interfaces, no functionality.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner May 4, 2023 23:31
@BeksOmega BeksOmega requested a review from cpcallen May 4, 2023 23:31
@github-actions github-actions bot added the PR: feature Adds a feature label May 4, 2023
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels May 5, 2023
@BeksOmega BeksOmega mentioned this pull request May 5, 2023
4 tasks
core/interfaces/i_icon.ts Outdated Show resolved Hide resolved
core/interfaces/i_icon.ts Outdated Show resolved Hide resolved
core/interfaces/i_icon.ts Outdated Show resolved Hide resolved
@BeksOmega BeksOmega enabled auto-merge (squash) May 8, 2023 21:05
@BeksOmega BeksOmega disabled auto-merge May 9, 2023 16:24
@BeksOmega BeksOmega merged commit 07db0c2 into google:develop May 9, 2023
@BeksOmega BeksOmega deleted the feat/iicon branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants