fix: Update category.ts to produce valid "aria-level" attributes #7033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogle#7027 The Aria level system starts with 1, but the variable 'this.level_' is zero-indexed and starts with 0, so be aware of this discrepancy when working with the code.
MarkusBordihn
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
|
Hi @MarkusBordihn :D Thanks for this fix! I'll leave Maribeth to review the PR, but wrt the conventional commits, since your PR only contains one commit you have to modify the commit message using |
maribethb
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Aria level system starts with 1, but the variable 'this.level_' is zero-indexed and starts with 0, so be aware of this discrepancy when working with the code.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #7027
Proposed Changes
Increase aria-level to start with 1 instead of 0.
Behavior Before Change
The aria-level starts with 0.
Behavior After Change
The aria-level starts with 1.
Reason for Changes
There are no aria-level with 0.
Test Coverage
Documentation
Additional Information
Refs: #7027