fix: disposing during dragging #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Apr 6, 2023
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Apr 6, 2023
(cherry picked from commit 2167afa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6945
Proposed Changes
Makes it so that block move events are not fired if a block was disposed during a drag.
Reason for Changes
Because of how disposing was rearranged during #6894 the block got removed from the workspace's list of blocks before the gesture was canceled. This meant that when the move event tried to find the block, it couldn't.
Test Coverage
Manual testing.
Documentation
N/A
Additional Information
I don't /think/ there are any other cases where this should be a problem. But if something like this comes up again we should look at rearranging the dispose order again.
Did not look into why this was not causing problems for drag targets (e.g. the trashcan) ¯\_(ツ)_/¯
This should probably go into tomorrow's patch as well.